Ensure closing of prompt; new validation rule for dates in d/m/y format. #858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it exists for the field.
To avoid daylight savings changeover creating a one hour difference, which causes the `day` portion to incorrect, and fail validation. Signed-off-by: Charlie Garrison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a couple of instances where prompts were not closing properly. First is for 'prettySelect' fields using a prefix or suffix; the class name used for the selector was wrong. The prefix/suffix need to be included in the class name.
There was a similar issue with prompts attached with 'jqv-prompt-at' not closing.
Change to the jquery.validationEngine-en.js file is a new validation rule for dates in the dd/mm/yyyy format.